Fix Docker and black CI builds #366
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The unversioned black build is failing. black is already specified (and frozen) in pre-commit, so we should re-use that. I've also updated the pre-commit config to modernise and match our other repos.
Scipy 1.11 now requires Py3.9+
It will be built to match Python/etc versions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The docker build is failing, as well as black (due to being unversioned -- so new releases broke it
I've disabled some of the whitespace (end-of-file) normalising checks in pre-commit as it looks like they were never run across the whole repository previously.