Added social icons on the left of the website and changed the title o… #183

RiyaGupta89 · 2021-06-02T08:05:31Z

…f the home page

Description

Please include a summary of the change and which issue is fixed. List any dependencies that are required for this change.

Fixed # (issue) (e.g. Fixed #8)

Type of change

Please check options that are relevant to your PR.

Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
This change requires a documentation update

Checklist:

I have squashed my commits
My code follows the style guidelines of this project
I have performed a self-review of my own code
I have commented my code, particularly in hard-to-understand areas
I have made corresponding changes to the documentation
My changes generate no new warnings

…f the home page

RiyaGupta89 · 2021-06-02T08:07:57Z

I have added social icons on the left of the website as it was mentioned in the issues section of the project. Please check it out. I hope you find it relevant.

Manvityagi

On smaller screens, the icons overlap with the text in main area.
Check the ideal behavior here: https://happy-shockley-488e36.netlify.app/
The exact same thing has been implemented here - Girl-Code-It/Opportunity-Calendar-Frontend#250

Also, GitHub icon is missing.

Thanks for the efforts and PR, appreciated :)

RiyaGupta89 · 2021-06-02T12:57:06Z

Do you want me to make it mobile friendly? I can do that.

…

On Wed, 2 Jun, 2021, 6:16 pm Manvi Tyagi, ***@***.***> wrote: ***@***.**** requested changes on this pull request. On smaller screens, the icons overlap with the text in main area. Check the ideal behavior here: https://happy-shockley-488e36.netlify.app/ The exact same thing has been implemented here - Girl-Code-It/Opportunity-Calendar-Frontend#250 <Girl-Code-It/Opportunity-Calendar-Frontend#250> Also, GitHub icon is missing. Thanks for the efforts and PR, appreciated :) — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#183 (review)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ARIR5XPAZYQXRXWAVHCMQ2DTQYRZPANCNFSM456HS6LA> .

Manvityagi · 2021-06-02T13:32:56Z

Do you want me to make it mobile friendly? I can do that.
…
On Wed, 2 Jun, 2021, 6:16 pm Manvi Tyagi, @.***> wrote: @Manvityagi requested changes on this pull request. On smaller screens, the icons overlap with the text in main area. Check the ideal behavior here: https://happy-shockley-488e36.netlify.app/ The exact same thing has been implemented here - Girl-Code-It/Opportunity-Calendar-Frontend#250 <Girl-Code-It/Opportunity-Calendar-Frontend#250> Also, GitHub icon is missing. Thanks for the efforts and PR, appreciated :) — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#183 (review)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/ARIR5XPAZYQXRXWAVHCMQ2DTQYRZPANCNFSM456HS6LA .

Yes, exactly

RiyaGupta89 · 2021-06-03T06:37:04Z

Made it mobile friendly. Do you want me to do something with the navbar links? Like hover effect or add active class on it?

Manvityagi · 2021-06-03T18:33:47Z

Made it mobile friendly. Do you want me to do something with the navbar links? Like hover effect or add active class on it?

You have made that part perfect!!
Here are a couple of thoughts:

It is fixed on bottom of screen, I liked it better on mid-screen like this
Infact, The layout itself , the size, color and positioning - I feel this way again suits more.

CC: @vaishali614 What do you think?

RiyaGupta89 · 2021-06-04T01:14:10Z

Fixed the links to the mid of the page and also changed the layout.

Manvityagi · 2021-06-04T07:19:40Z

Fixed the links to the mid of the page and also changed the layout.

Awesome, One last change - The headline should be "From Will to Skill", There is also an issue #177 for the same.

RiyaGupta89 · 2021-06-04T10:50:06Z

Yes. Done.

Manvityagi

Other than little changes in the comments,

See this GIF, From around 763w to 663, the blue line is above the text.

If you see the original website, this transition is smooth and consistent.

Manvityagi · 2021-06-04T11:12:47Z

src/homepage/Components/Banner.js

      <Container className={styles.container}>
        <Row>
          <Col md={6} lg={7}>
            <h1 className={styles.heading}>
-              Give wings to <br className={styles.align} /> your
+              Embrace <br className={styles.align} /> your


From Will to Skill here too

Manvityagi · 2021-06-04T11:14:58Z

src/homepage/Components/Banner.js

      <Container className={styles.containersmall} fluid>
        <h1 style={{ textAlign: "center" }} className={styles.heading}>
-          Give wings to <br className={styles.align} /> your
-          <span style={{ color: "#008dc8" }}> dreams </span>
+          From Will to <br className={styles.align} /> to


From Will to to Skill.

To is two times here

Have a look now.

The layout "From Will to Skill" needs to be revised, because the text is small, it isn't looking good on the banner.

Let's do one thing, Revert all your changes in the banner, (Keep it the original one - Give wings to your dreams), and just give social media icons in this PR. I will merge right away.

Manvityagi

Awesome Work @RiyaGupta08. Thanks for the PR. Merging this

Added social icons on the left of the website and changed the title o…

8cd028f

…f the home page

Manvityagi requested changes Jun 2, 2021

View reviewed changes

Made it mobile friendly

ac16901

Styled social links

df4ed62

Manvityagi mentioned this pull request Jun 4, 2021

Social Media Icons on Left of website #171

Closed

Changed the headline

6d914fd

Manvityagi requested changes Jun 4, 2021

View reviewed changes

riyaagupta89 added 2 commits June 5, 2021 05:46

Made minor changes

c1264d2

Have revert all the changes

ae4a181

Manvityagi approved these changes Jun 6, 2021

View reviewed changes

Manvityagi merged commit b6fd4e0 into Girl-Code-It:develop Jun 6, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Added social icons on the left of the website and changed the title o… #183

Added social icons on the left of the website and changed the title o… #183

RiyaGupta89 commented Jun 2, 2021 •

edited

Loading

RiyaGupta89 commented Jun 2, 2021

Manvityagi left a comment

RiyaGupta89 commented Jun 2, 2021 via email

Manvityagi commented Jun 2, 2021

RiyaGupta89 commented Jun 3, 2021

Manvityagi commented Jun 3, 2021

RiyaGupta89 commented Jun 4, 2021

Manvityagi commented Jun 4, 2021

RiyaGupta89 commented Jun 4, 2021

Manvityagi left a comment •

edited

Loading

Manvityagi Jun 4, 2021

Manvityagi Jun 4, 2021

RiyaGupta89 Jun 5, 2021

Manvityagi Jun 5, 2021

Manvityagi left a comment

Added social icons on the left of the website and changed the title o… #183

Added social icons on the left of the website and changed the title o… #183

Conversation

RiyaGupta89 commented Jun 2, 2021 • edited Loading

Description

Type of change

Checklist:

RiyaGupta89 commented Jun 2, 2021

Manvityagi left a comment

Choose a reason for hiding this comment

RiyaGupta89 commented Jun 2, 2021 via email

Manvityagi commented Jun 2, 2021

RiyaGupta89 commented Jun 3, 2021

Manvityagi commented Jun 3, 2021

RiyaGupta89 commented Jun 4, 2021

Manvityagi commented Jun 4, 2021

RiyaGupta89 commented Jun 4, 2021

Manvityagi left a comment • edited Loading

Choose a reason for hiding this comment

Manvityagi Jun 4, 2021

Choose a reason for hiding this comment

Manvityagi Jun 4, 2021

Choose a reason for hiding this comment

RiyaGupta89 Jun 5, 2021

Choose a reason for hiding this comment

Manvityagi Jun 5, 2021

Choose a reason for hiding this comment

Manvityagi left a comment

Choose a reason for hiding this comment

RiyaGupta89 commented Jun 2, 2021 •

edited

Loading

Manvityagi left a comment •

edited

Loading