fix(travis): unset _JAVA_OPTIONS for compile_frontend.py #3354
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
jopjop74
approved these changes
Sep 18, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #3338
Unfortunately ChromeDevTools/devtools-frontend@5e7e9ca wasn't successful. Something else in
compile_frontend.pyis dependent on the exact output of the compiler and is breaking the build.In the Travis bug for this, unsetting the variable is mentioned as working, and though there is a concern that the new default JVM will run out of memory, it appears to work for us so let's go with it for now unless it ends up flaky.
travis-ci/travis-cookbooks#895 suggests Travis may move to using
JAVA_TOOL_OPTIONSwhich won't get printed to stdout, so we may be able to remove this line again in the future.