Add WIP instrumentation quickstart sample #326
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The docs under docs/examples are for https://google-cloud-opentelemetry.readthedocs.io/en/latest/. Let just leave it in /samples for now |
|
I'm going to switch to manual instrumentation |
dashpole
force-pushed
the
initial_gcp_sample
branch
from
84ccaa1
to
a2227b0
Compare
|
I think this is ready for review. The app builds and runs successfully, but it does not include any instrumentation. I'll do that as follow-ups |
|
@aabmass any recommendation on testing this as part of CI? Should I use cloud build similar to the java quickstart? |
aabmass
approved these changes
May 9, 2024
Co-authored-by: Aaron Abbott <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is mostly boilerplate to make future PRs smaller.
The following are taken from #309:
samples/instrumentation-quickstart/Dockerfilesamples/instrumentation-quickstart/app.pyThe following are minimally adapted from the java quickstart:
The quickstart runs and serves requests, but does not currently include any instrumentation. The logs are also not in the correct format.
I noticed we have some examples in docs/examples, and another example in /samples. Should we consolidate?