Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding username who has PAT[not owner] #13

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Adding username who has PAT[not owner] #13

wants to merge 1 commit into from

Conversation

SC-One
Copy link

@SC-One SC-One commented Apr 30, 2024 •
edited by GuillaumeFalourd
Loading

Closes #12

Evidences

TODO

@SC-One SC-One mentioned this pull request Apr 30, 2024
Open
@GuillaumeFalourd
Copy link
Owner

GuillaumeFalourd commented Apr 30, 2024 •
edited
Loading

Hi @SC-One ! Thank you for contributing 👍🏼

Could you please follow the contribution guidelines and make sure you tested your implementation for each OS runner with GHA workflows on your fork? (you could then share your evidences in the PR description above)

More over, I observed you added an input that will change the current behavior. To avoid breaking changes, I would suggest adding a new if [ "${{ inputs.third-user }}" = "true" ]; then condition and perform the git clone command using https://${{ inputs.third-user }}:${{ inputs.access-token }} only in that case.

Does ii make sense?

@GuillaumeFalourd GuillaumeFalourd added enhancement New feature or request Waiting for return Waiting for return labels Apr 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@SC-One SC-One

Labels
enhancement New feature or request Waiting for return Waiting for return
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Clone with member of the repo[not owner]
2 participants
@SC-One @GuillaumeFalourd