Run tests with h5py in workflow #193
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattjala
changed the title
jreadey
approved these changes
May 1, 2024
.github/workflows/main.yml
Outdated
| env: | ||
| HS_USERNAME: test_user1 | ||
| HS_PASSWORD: test | ||
| TEST2_USERNAME: test_user1 |
| HS_USERNAME: test_user1 | ||
| HS_PASSWORD: test | ||
| TEST2_USERNAME: test_user1 | ||
| TEST2_PASSWORD: test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A few changes to the tests are necessary for this workflow to pass:
test_index_emptylistis expected to fail because h5pyd returns an empty array with no shape, and numpy returns an empty array with the shape(0, 3). Now, when h5pyd is returning an empty selection, it sets the 'shape' equal to what would result from executing the same (empty) selection on an ndarray.test_ellipsisandtest_tupleunderTestScalarArrayare expected to raise an error due toH5T_ARRAYonly being partially implemented in HSDS. For now, if h5py is being used, these tests manually raise an error to be consistent.is_hdf5on an ID when using h5py, since the h5py implementation of that function expects a string path, not an integer ID.