WIP: New HTTPConn for each obj in file #195
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattjala
force-pushed
the
multiple_conns_per_file
branch
from
b1d9be4
to
3b5b075
Compare
|
Testing on the icesat2 benchmark didn't show any changes in performance from this. It's simpler just to keep one connection per file. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MultiManager generally needs multiple HttpConns in order to provide a performance boost. For multiple dsets in a single file (a common use case), the MultiManager's effectiveness was limited.
In order to avoid issues in tests with group creation/deletion not being detected, the cache must be disabled when those files are opened. For that reason, this should probably be considered a breaking API change.