Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: unpublishable config & demo-theme #161

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

se09deluca
Copy link

@se09deluca se09deluca commented Apr 26, 2024

Currently the configs and demo theme are publishable only if schema has been already migrated.
This PR aims to make the config publishable before the schema migration.

Since the name of database depends on the config, publishing the config before schema migration gives a more linear installation flow.

if (Schema::hasTable(config('pagebuilder.storage.database.prefix').'settings')) {

Related issue:
#155

@Shaz3e
Copy link

Shaz3e commented Jun 22, 2024

This needs to be merged as I cannot run the command to publish the config

php artisan vendor:publish --provider="HansSchouten\LaravelPageBuilder\ServiceProvider" --tag=config

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants