feat: Implimentation for revoking only when data in wallet changes #184
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Judge40
requested changes
Jun 27, 2024
src/main/java/uk/nhs/hee/tis/trainee/credentials/dto/PlacementCredentialDto.java
Outdated
Show resolved
Hide resolved
src/main/java/uk/nhs/hee/tis/trainee/credentials/dto/ProgrammeMembershipCredentialDto.java
Outdated
Show resolved
Hide resolved
src/main/java/uk/nhs/hee/tis/trainee/credentials/event/PlacementEventListener.java
Outdated
Show resolved
Hide resolved
src/main/java/uk/nhs/hee/tis/trainee/credentials/event/PlacementEventListener.java
Outdated
Show resolved
Hide resolved
src/main/java/uk/nhs/hee/tis/trainee/credentials/event/ProgrammeMembershipEventListener.java
Outdated
Show resolved
Hide resolved
src/main/java/uk/nhs/hee/tis/trainee/credentials/event/ProgrammeMembershipEventListener.java
Outdated
Show resolved
Hide resolved
src/main/java/uk/nhs/hee/tis/trainee/credentials/service/RevocationService.java
Outdated
Show resolved
Hide resolved
src/main/java/uk/nhs/hee/tis/trainee/credentials/service/RevocationService.java
Outdated
Show resolved
Hide resolved
Judge40
previously requested changes
Jul 1, 2024
src/main/java/uk/nhs/hee/tis/trainee/credentials/dto/PlacementCredentialDto.java
Outdated
Show resolved
Hide resolved
refactor: sonarcloud issues refactor: sonarcloud issues refactor: remove old hash method test: test for md5Hash refactor: seperate MD5 hash method into seperate utill file to decrease code duplication github comments and tests test: update tests feat: Github Comments
EdwardBarclay
force-pushed
the
only_revoke_credentials_when_data_in_wallet_changes
branch
from
145af32
to
29752be
Compare
|
|
@EdwardBarclay are you set up for testing on stage? |
Nope I was just thinking about that before merging |
|
Rats. My staging access is also a bit broken at present (I think my identity credential is for the old server). Let's chat tomorrow and see if we can get something working... |
EdwardBarclay
deleted the
only_revoke_credentials_when_data_in_wallet_changes
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TICKET TIS21-6067