Rename Boolean fields to provide standard isXXX getter #46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey, @drekbour I completely forgot about that issue! Thanks for fixing this! 🎉 What other changes do you have in mind? (you can merge this one) |
|
perf items and further generalisations (notably not requiring SatelliteData at all). I'll add to this 'using kotlin' (which is why I want a java sample so I don't unknowingly break the api). I'll try to group these up and PR sequentially. First up is figuring out how to write a JMH test in kotlin+gradle. |
|
What's a JMH test? |
|
Hah, never tried it so far! Sounds interesting. So I approved this PR, you can merge it if you want! |
|
I don't have a merge option anywhere. |
|
Weird. I merged it though! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rename resolving #42. I have a bunch of changes I would like to make (*) so am testing to see if PRs are accepted : )
(*) I actually did many refactorings years ago against hexameter but didn't share.