Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove weight properties and use time_estimate in LLT #87

Merged
merged 3 commits into from
Jun 27, 2023

Conversation

abouteiller
Copy link
Contributor

Match the new parsec API after ICLDisco/parsec#517

@abouteiller abouteiller requested a review from a team as a code owner June 3, 2023 01:24
@abouteiller abouteiller self-assigned this Jun 6, 2023
@abouteiller abouteiller added the blocker Blocking release or critical use case label Jun 6, 2023
@QingleiCao
Copy link

Please let me know when this will be merged. I need this PR and PR #57, but it seems these two PRs have conflicts if both are applied.

@abouteiller
Copy link
Contributor Author

@QingleiCao did you try this individually? If so and there was no problem please review and then I'll merge it.

Copy link

@QingleiCao QingleiCao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's better to make these **_time_estimate global and shared; otherwise, LGTM.

src/zpotrf_L.jdf Show resolved Hide resolved
src/zpotrf_L.jdf Show resolved Hide resolved
@abouteiller abouteiller merged commit 966c04d into ICLDisco:master Jun 27, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocker Blocking release or critical use case
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants