Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Translations: Bugfix, drop columns, new defaults #1019

Merged
merged 5 commits into from
Mar 2, 2024
Merged

Conversation

matentzn
Copy link
Contributor

@matentzn matentzn commented Mar 2, 2024

This PR:

  • Changes a few default values for the new international edition
  • Adds a new feature to drop unsupported columns during the preparation process
  • Fixes a wrong references in the owl conversion of the translations

@matentzn matentzn requested a review from gouttegd March 2, 2024 14:16
gouttegd
gouttegd previously approved these changes Mar 2, 2024
Copy link
Contributor

@gouttegd gouttegd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I approve, but please see my remarks about the use of a string-typed parameter in the config file (both for the newly added drop_unknown_columns and the other parameters added in #1006). They should really be boolean parameters.

(I am not requesting any change since it’s my fault for not having caught this mistyping before. Your call whether you want to change the type or not.)

odk/odk.py Outdated Show resolved Hide resolved
odk/odk.py Outdated Show resolved Hide resolved
template/src/ontology/Makefile.jinja2 Outdated Show resolved Hide resolved
@matentzn
Copy link
Contributor Author

matentzn commented Mar 2, 2024

Thank you, I also tested your suggestion and it works perfect.

Copy link
Contributor

@gouttegd gouttegd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Glad that you agreed with the proposed change, but then it should be done correctly. It’s not enough to assign a default value of True or False – the option itself needs to be declared as bool. Otherwise you’re merely declaring a string-typed option that happens to have a default value of True or False.

odk/odk.py Outdated Show resolved Hide resolved
@matentzn matentzn requested a review from gouttegd March 2, 2024 16:03
@matentzn matentzn merged commit baf9a8e into master Mar 2, 2024
1 check passed
@matentzn matentzn deleted the last-fixes branch March 2, 2024 17:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants