Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HOTFIX: Fix the qc.yml to not run mirrors #1022

Merged
merged 1 commit into from
Mar 2, 2024
Merged

HOTFIX: Fix the qc.yml to not run mirrors #1022

merged 1 commit into from
Mar 2, 2024

Conversation

matentzn
Copy link
Contributor

@matentzn matentzn commented Mar 2, 2024

This is necessary to be pushed as a hotfix quickly, as some QC pipelines can run mirrors without failing.

I didnt notice this because of chicken egg - I couldnt test qc.yml directly, and it failed because it was not able to find the v1.5 ODK release..

@matentzn matentzn requested a review from gouttegd March 2, 2024 20:23
Copy link
Contributor

@gouttegd gouttegd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No objection to the fix. But I am not sure I understand why this is necessary.

Making the mirror-downloading rules independent of IMP was done to allow custom workflows to depend on a mirror independently of the import pipeline.

But as far as I know, in the standard workflows, the mirrors are only used to refresh the imports, so if we run with IMP=false, no refresh of the imports should be attempted and therefore no mirror-downloading rule should be invoked.

@matentzn
Copy link
Contributor Author

matentzn commented Mar 2, 2024

Maybe the pipelines that failed because of this failed because of custom goals.

This seems to have been the case with OBA: https://github.com/obophenotype/bio-attribute-ontology/actions/runs/8125158836/job/22207444205

But with MAXO it seems to me that mirror/merged.owl was being created for some reason during the QC. this i perhaps because mirror-% is PHONY and therefore executed no matter what?

@matentzn matentzn merged commit 79e1de4 into master Mar 2, 2024
1 check passed
@matentzn matentzn deleted the fix-test branch March 2, 2024 20:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants