Fix use of ODK_BINDS option. #1050
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The run.sh script is supposed to allow specifying extra bindings between the local filesystem and the container, with a `ODK_BINDS` option in the `run.sh.conf` file: ``` ODK_BINDS=/path/to/my/local/dir:/path/to/the/container/mount/point ``` This currently doesn't work when using the Docker (standard) backend because of a single missing `g` option to the sed command that converts the value of `ODK_BINDS` into `-v` options to pass to `docker run`. This commit simply adds the missing `g` option.
anitacaron
approved these changes
Apr 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The run.sh script is supposed to allow specifying extra bindings between the local filesystem and the container, with a
ODK_BINDSoption in therun.sh.conffile:This currently doesn't work when using the Docker (standard) backend because of a single missing
goption to the sed command that converts the value ofODK_BINDSinto-voptions to pass todocker run.This PR simply adds the missing
goption.