-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade base system to Ubuntu 24.04 #1076
base: master
Are you sure you want to change the base?
Commits on Jun 24, 2024
-
This should have been done right after the 1.5 release, so let's do it now.
Configuration menu - View commit details
-
Copy full SHA for a6f014a - Browse repository at this point
Copy the full SHA a6f014aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 889ecc5 - Browse repository at this point
Copy the full SHA 889ecc5View commit details -
Explicitly install the NPM package manager.
The NodeJs package manager (NPM) is no longer automatically installed when we install NodeJS, so we ask for it explicitly. We need it to install Obographviz. Ideally it should be possible to install both NPM and Obographviz in the builder image and then to transfer only Obographviz to the final ODKFull image, thereby reducing the clutter in ODKFull, but this will need further investigation.
Configuration menu - View commit details
-
Copy full SHA for 50b0113 - Browse repository at this point
Copy the full SHA 50b0113View commit details -
This is a runtime dependency of Konclude (even the statically compiled one that we use on x86_64). It was probably automatically pulled by another package on Ubuntu 22.04, but it is not on 22.04, so we need to ask for it explicitly.
Configuration menu - View commit details
-
Copy full SHA for a59ceb9 - Browse repository at this point
Copy the full SHA a59ceb9View commit details -
Force system-wide installation of OBO Dashboard.
Pip is now by default refusing to install anything in the system-wide Python library path, which is considered the "private garden" of the underlying operating system (e.g., on Ubuntu, only APT tools should add Python packages to the system-wide path). This may be fine in general, in a user-facing scenario, but not for the ODK which is in effect a "read-only" system overall. The OBO Dashboard is part of the tools/libraries we provide with the ODK and there is no reason for us to package it separately inside a virtual environment (the recommended way of installing non-system Python packages) -- the entire ODK is already a "virtual environment". Ultimately the right thing to do here would be for the OBO Dashboard upstream to make proper releases, which we could then install at the same time as any other Python packages.
Configuration menu - View commit details
-
Copy full SHA for d966f35 - Browse repository at this point
Copy the full SHA d966f35View commit details -
Update the main ODK script for newer Python.
The odk.py script has some issues when we run it under Python 3.12, we fix them here.
Configuration menu - View commit details
-
Copy full SHA for 40670a5 - Browse repository at this point
Copy the full SHA 40670a5View commit details -
Do not install virtualenv in the builder image.
Installing virtualenv in the builder image has nafarious consequences when we try to later install Python packages. That's because the Ubuntu package for virtualenv automatically installs platformdirs version 2.5.1, which then prevents us from installing the platformdirs 4.x that we need as a dependency for some of our packages. The only reason we had virtualenv in the builder image was that we use it to run the update-constraints workflow (in which we try to install all our Python packages in a virtualenv). So here, we 1) remove virtualenv from the builder image; 2) amend the update-constraints.sh script to make it install virtualenv itself.
Configuration menu - View commit details
-
Copy full SHA for 2adc44e - Browse repository at this point
Copy the full SHA 2adc44eView commit details -
Silence Python warning about staged installation.
PIP emits a warning when we attempt to install executable scripts in a location that is not in the system PATH. In this instance the warning is not warranted. The scripts are installed in a staging location ON PURPOSE -- they are later copied over to the final ODK images, where the scripts will end up in the system PATH. So we shut that warning down.
Configuration menu - View commit details
-
Copy full SHA for 4cc125b - Browse repository at this point
Copy the full SHA 4cc125bView commit details -
Get freshly frozen Python constraints for the newer version of Python provided in Ubuntu 24.04.
Configuration menu - View commit details
-
Copy full SHA for a8d7605 - Browse repository at this point
Copy the full SHA a8d7605View commit details
Commits on Jun 27, 2024
-
Revert "Update to newest owltools to align OWL API with ROBOT 1.9.6"
This reverts commit 716a6b6.
Configuration menu - View commit details
-
Copy full SHA for 72307ef - Browse repository at this point
Copy the full SHA 72307efView commit details -
Configuration menu - View commit details
-
Copy full SHA for 99a9619 - Browse repository at this point
Copy the full SHA 99a9619View commit details