Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update minor version in Makefile to 1.6 #1081

Merged
merged 1 commit into from
Jul 4, 2024
Merged

Update minor version in Makefile to 1.6 #1081

merged 1 commit into from
Jul 4, 2024

Conversation

matentzn
Copy link
Contributor

@matentzn matentzn commented Jul 4, 2024

Updating minor version in Makefile, primarily so that my regular dev snapshot releases are correctly tagged with 1.6-dev rather than 1.5-dev.

@matentzn
Update minor version in Makefile
a5441f1 
Updating minor version in Makefile, primarily so that my regular `dev` snapshot releases are correctly tagged with 1.6-dev rather than 1.5-dev.
@matentzn matentzn requested a review from gouttegd July 4, 2024 17:23
gouttegd
gouttegd approved these changes Jul 4, 2024
View reviewed changes
Copy link
Contributor

@gouttegd gouttegd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Usually it’s best to do that right after a release, for the very reason you mention in the message.

Since it was not done right after 1.5, obviously no objection to doing it now.

@matentzn matentzn merged commit 3b8504b into master Jul 4, 2024
1 check passed
@matentzn matentzn deleted the makefile16 branch July 4, 2024 18:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gouttegd gouttegd gouttegd approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@matentzn @gouttegd