Some improvements to alpha blending in GDI #460
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This does still not work, but it corrects a few bugs that would additionally hinder it from working. When moving the cursor over the gradient, it does now flicker and "try" to display a gradient. At this point, I am not sure which component is not properly supporting the alpha channel and causing the gradient to not display properly.
dumblob
reviewed
May 12, 2022
demo/gdi/nuklear_gdi.h
Outdated
| } | ||
|
|
||
| static void | ||
| nk_gdi_rect_multi_color(HDC dc, short x, short y, unsigned short w, | ||
| unsigned short h, struct nk_color left, struct nk_color top, | ||
| struct nk_color right, struct nk_color bottom) | ||
| { | ||
| /* Note that GDI (without plus) does not appear to support alpha transparency properly in gradients. */ |
There was a problem hiding this comment.
Could you also add one or two words about how it manifests itself visually (I mean the "flickering")? Thanks!
There was a problem hiding this comment.
Sure, when hovering and moving the mouse over the color picker matrix, the displayed gradient flickers to black.
I've prepared a short video: https://www.youtube.com/watch?v=oaEzvqKD_fo
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This does still not work, but it corrects a few bugs that would additionally hinder it from working.
When moving the cursor over the gradient, it does now flicker and "appear" to display a gradient (probably just a redraw effect).
At this point, I am not sure which component is not properly supporting the alpha channel and causing the gradient to not display properly. From what I gathered searching, it is probably 37-year-old GDI itself.