Security improvements #73
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds user impersonation for both helm and kubectl.
New region configuration attribute
authenticationMode:admin: each helm / kubectl calls are done with onyxia-api permissions (cluster-admin). This is the defaultimpersonate: each helm / kubectl call (except for onboarding) is done impersonating the user. This is the more secure but not compatible with in-cluster configuration and requires helm 3.4.0+ ( see helm/helm@9429af8#diff-ab0b247f8d73a6afc9c64237096ddb96ca5df0558fe5f5da64f493c2abad4be5)userToken? : each helm / kubectl call (except for onboarding) is done using the user's token. This is the most secure.This PR also adds kubectl user impersonation.
This PR also bumps the docker-bundled helm version to 3.4.0-RC1.
This PR also adds
usernamePrefixconfiguration in region.This PR also disables CORS by default,
security.cors.allowed_originscan be set to re-enable it.