Add missing kernels, rename FfmpegBicubic #18
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LightArrowsEXE
force-pushed
the
adobe-bicubic
branch
from
91c0384
to
b7d50f5
Compare
|
Ripbozo i can't complain for ffmpeg since it's not even on a minor version |
|
AdobeBicubicSharper/AdobeBicubicSmoother make no sense since blur isn't implemented in resize. Should first implement custom kernels. |
Can we at least accept the other change then? FfmpegBicubic stinx :( |
|
Why? Where else is swscale popularily used if not ffmpeg |
|
The name implies that it's a default used everywhere in ffmpeg, whereas from my understanding it's just the Swscale default, not a global one. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding missing kernels we uncovered some time ago, as well as renaming FfmpegBicubic.