The long road to GTK4

[JakeStanger]

GTK4 introduces a lot of breaking changes, mostly involving event handling. This PR will track the progress of the port. It's going to take me a while to get through it all, and this will be secondary to continuing bar development.

If you want to (attempt to) build this, you currently need to manually build/install gtk4-layer-shell and set the following env vars:

export PKG_CONFIG_PATH=/usr/local/lib/pkgconfig
export LD_LIBRARY_PATH=/usr/local/lib

[yavko]

I see that nix build is failing due to graphene missing, adding it to https://github.com/JakeStanger/ironbar/blob/master/flake.nix#L114 should fix it

[JakeStanger]

Added, cheers

[yavko]

Lol it seems you also need to change gtk3 to gtk4, and gtk-layer-shell to gtk4-layer-shell :P

[yavko]

Also dy why format check is failing, maybe you need to run cargo fmt?

[JakeStanger]

Lol it seems you also need to change gtk3 to gtk4, and gtk-layer-shell to gtk4-layer-shell :P

Cool done. Should have spotted those ones lol

Also dy why format check is failing, maybe you need to run cargo fmt?

Probably. I've still got 73 compiler errors to work through before I can even start looking at runtime issues, so I'm not too worried about polishing it up yet :p

[yavko]

Lol it seems you also need to change gtk3 to gtk4, and gtk-layer-shell to gtk4-layer-shell :P

Cool done. Should have spotted those ones lol

Also dy why format check is failing, maybe you need to run cargo fmt?

Probably. I've still got 73 compiler errors to work through before I can even start looking at runtime issues, so I'm not too worried about polishing it up yet :p

ah

[yavko]

i was stupid, that was the devshell lmao, i also removed stray cuz it aint used no more

diff --git a/nix/default.nix b/nix/default2.nix
index 731e7ac..9be5772 100644
--- a/nix/default.nix
+++ b/nix/default2.nix
@@ -1,5 +1,5 @@
 {
-  gtk3,
+  gtk4,
   gdk-pixbuf,
   librsvg,
   webp-pixbuf-loader,
@@ -9,12 +9,13 @@
   shared-mime-info,
   gsettings-desktop-schemas,
   wrapGAppsHook,
-  gtk-layer-shell,
+  gtk4-layer-shell,
   gnome,
   libxkbcommon,
   openssl,
   pkg-config,
   hicolor-icon-theme,
+  graphene,
   rustPlatform,
   lib,
   version ? "git",
@@ -30,9 +31,9 @@
       path = lib.cleanSource ../.;
     };
     nativeBuildInputs = [pkg-config wrapGAppsHook gobject-introspection];
-    buildInputs = [gtk3 gdk-pixbuf glib gtk-layer-shell glib-networking shared-mime-info gnome.adwaita-icon-theme hicolor-icon-theme gsettings-desktop-schemas libxkbcommon openssl];
+    buildInputs = [gtk4 gdk-pixbuf glib gtk4-layer-shell glib-networking shared-mime-info gnome.adwaita-icon-theme hicolor-icon-theme gsettings-desktop-schemas libxkbcommon openssl graphene];
     propagatedBuildInputs = [
-      gtk3
+      gtk4
     ];
     preFixup = ''
       gappsWrapperArgs+=(
@@ -91,5 +92,4 @@ in
         buildFeatures = features;
         cargoDeps = rustPlatform.importCargoLock {lockFile = ../Cargo.lock;};
         cargoLock.lockFile = ../Cargo.lock;
-        cargoLock.outputHashes."stray-0.1.3" = "sha256-7mvsWZFmPWti9AiX67h6ZlWiVVRZRWIxq3pVaviOUtc=";
       })