docs: Update share-theme.md to clarify output filename #5028
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added clarification that the output file will literally be `.png` - when I first ran the command I couldn't see an export then realised it was called this and hidden by default as it's a dotfile. Not sure if it might be worth changing it so that if no export filename is specified a default (e.g., `omptheme.png` or similar) is used to stop it ended up being a hidden file?
|
@EDIflyer it makes sense to add a sane default name. Also, for configurations that start with a dot, we best strip those as well. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prerequisites
Description
Added clarification that the output file will literally be
.png- when I first ran the command I couldn't see an export then realised it was called this and hidden by default as it's a dotfile.Not sure if it might be worth changing it so that if no export filename is specified a default (e.g.,
omptheme.pngor similar) is used to stop it ended up being a hidden file? For just now I've just updated the docs though.