Update config.js #2
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated config.js to use Regex expressions when looking at url provided by user for background
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/jaredkent/start-wave/1w8c2o9qq |
Jaredk3nt
reviewed
Sep 29, 2020
src/utils/config.js
Outdated
| // TODO: replace conditions with regex | ||
| config.wallpaper.startsWith('http') || | ||
| config.wallpaper.startsWith('https') | ||
| config.wallpaper.match(/(http:\/\/)|(https:\/\/)/) |
There was a problem hiding this comment.
Can we switch to test over match on both of these? It's a bit more straight forward although they technically give the same outcome here.
|
@anarchylimes Thanks for the PR! Sorry I missed it open, hadn't checked my github notifications in awhile. I added two small comments and then I will totally get it merged |
switch to regex.test rather than str.match
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated config.js to use regex expressions when looking at url provided by user for background