Merge pull request #135 from JaseZiv/cran

Cran
JaseZiv · Jun 15, 2022 · 0474966 · 0474966
2 parents 2323439 + 578e56b
commit 0474966
Show file tree

Hide file tree

Showing 14 changed files with 37 additions and 25 deletions.
diff --git a/DESCRIPTION b/DESCRIPTION
@@ -1,12 +1,13 @@
 Type: Package
 Package: worldfootballR
-Title: Functions to Extract and Clean World Football (Soccer) Data
-Version: 0.5.3.4000
+Title: Extract and Clean World Football (Soccer) Data
+Version: 0.5.6
 Authors@R: c(
     person("Jason", "Zivkovic", , "[email protected]", role = c("aut", "cre", "cph")),
-    person("Tony", "ElHabr", , "[email protected]", role = "ctb")
+    person("Tony", "ElHabr", , "[email protected]", role = "ctb"),
+      person(given = "Tan", family = "Ho", , "[email protected]", role = "ctb")
   )
-Description: A set of functions to allow users to obtain clean and tidy
+Description: Allow users to obtain clean and tidy
     football (soccer) game, team and player data. Data is collected from a
     number of popular sites, including 'FBref'<https://fbref.com/en/>,
     transfer and valuations data from
@@ -47,7 +48,5 @@ Suggests:
     knitr,
     rmarkdown,
     testthat
-VignetteBuilder: 
-    knitr
 Encoding: UTF-8
-RoxygenNote: 7.1.2
+RoxygenNote: 7.2.0
diff --git a/NEWS.md b/NEWS.md
@@ -1,15 +1,25 @@
-# worldfootballR 0.5.3.4000
+# worldfootballR 0.5.6
+
+* CRAN submission
+
+***
+
+# worldfootballR 0.5.3.4001
 
 ### Bugs
 
 * `player_transfer_history()` no longer throwing errors for retired players and also addressed changed HTML on transfermarkt returning no data [#127](https://github.com/JaseZiv/worldfootballR/issues/127)
 
+***
+
 # worldfootballR 0.5.3.3000
 
 ### Bugs
 
 * `fotmob_get_league_ids()` - now uses new endpoint for league ids (data in script element no longer has data). This function is internally used by `fotmob_get_league_matches()`, `fotmob_get_league_tables()`, and `fotmob_get_season_stats()`, which would have been broken if `cached=FALSE` was specified.
 
+***
+
 # worldfootballR 0.5.3.2000
 
 ### Improvements
@@ -62,7 +72,7 @@ Now starting to have load functions:
 ### Bugs
 
 * `tm_player_bio()` addresses where some data points don't exist for some players and returns NAs
-* `understat_team_stats_breakdown()` now resturns the correct `season_start_year` value [#119](https://github.com/JaseZiv/worldfootballR/issues/119)
+* `understat_team_stats_breakdown()` now returns the correct `season_start_year` value [#119](https://github.com/JaseZiv/worldfootballR/issues/119)
 * tests and vignettes for fotmob stat functions changed to lowercase for second word in `stat_name` [#118](https://github.com/JaseZiv/worldfootballR/issues/118)
 
 ***
@@ -85,7 +95,7 @@ Now starting to have load functions:
 ### Improvements / Breaking Changes
 
 * Additional processing logic added such that `fotmob_get_league_tables` works properly for international tournaments.
-* The `stat_type` argument in `fotmob_get_seasons_stats` renamed to `stat_name` to reflect the different set of values that it takes. Valid values are now equivalent to the options that can be found on the stats page in the browser, e.g. [the Liverpool player stats page](https://www.fotmob.com/leagues/47/stats/season/16390/players/goals/team/8650/liverpool-players). Previously the values came from [a custom, pre-saved dataframe](https://raw.githubusercontent.com/JaseZiv/worldfootballR_data/master/raw-data/fotmob-stats/stat_types.csv).
+* The `stat_type` argument in `fotmob_get_seasons_stats` renamed to `stat_name` to reflect the different set of values that it takes. Valid values are now equivalent to the options that can be found on the stats page in the browser, e.g. [the Liverpool player stats page](https://www.fotmob.com/leagues/47/stats/season/16390/players/goals/team/8650/liverpool-players). 
 
 ***
 
@@ -124,7 +134,7 @@ Now starting to have load functions:
 
 ### Improvements
 
-* `fotmob_get_league_matches` and `fotmob_get_league_tables` now check 2 places for the league endpoint since it changes occassionally.
+* `fotmob_get_league_matches` and `fotmob_get_league_tables` now check 2 places for the league endpoint since it changes occasionally.
 * `fotmob_get_match_players` gets 3 additional columns: `match_id`, `team_id`, `team_name`. [#105](https://github.com/JaseZiv/worldfootballR/issues/105)
 
 ***

diff --git a/R/fotmob_stats.R b/R/fotmob_stats.R
@@ -93,7 +93,7 @@
 #' `stat_name` must be one of the following for \code{"player"}:
 #'
 #' \itemize{
-#' #' \item{Accurate long balls per 90}
+#' \item{Accurate long balls per 90}
 #' \item{Accurate passes per 90}
 #' \item{Assists}
 #' \item{Big chances created}

diff --git a/R/tm_matchday_table.R b/R/tm_matchday_table.R
@@ -5,7 +5,7 @@
 #' @param country_name the country of the league's players
 #' @param start_year the start year of the season (2020 for the 20/21 season)
 #' @param matchday the matchweek number. Can be a vector of matchdays
-#' @param league_url league url from transfermarkt.com. To be used when country_name not avalilable in main function
+#' @param league_url league url from transfermarkt.com. To be used when country_name not available in main function
 #'
 #' @return returns a dataframe of the table for a selected league and matchday
 #'

diff --git a/R/tm_team_transfer_balances.R b/R/tm_team_transfer_balances.R
@@ -4,7 +4,7 @@
 #'
 #' @param country_name the country of the league's players
 #' @param start_year the start year of the season (2020 for the 20/21 season)
-#' @param league_url league url from transfermarkt.com. To be used when country_name not avalilable in main function
+#' @param league_url league url from transfermarkt.com. To be used when country_name not available in main function
 #'
 #' @return returns a dataframe of the summarised financial transfer performance of all teams for a league season
 #'

diff --git a/R/understat_shots.R b/R/understat_shots.R
@@ -2,7 +2,7 @@
 #'
 #' Returns shooting locations for all matches played in the selected league season from Understat.com
 #'
-#' @param league the avaliable leagues in Understat as outlined below
+#' @param league the available leagues in Understat as outlined below
 #' @param season_start_year the year the season started
 #'
 #' The leagues currently available for Understat are:

diff --git a/R/worldfootballr_helpers.R b/R/worldfootballr_helpers.R
@@ -131,7 +131,7 @@ fb_player_urls <- function(team_url, time_pause=3) {
 #'
 #' @param country_name the country of the league's players
 #' @param start_year the start year of the season (2020 for the 20/21 season)
-#' @param league_url league url from transfermarkt.com. To be used when country_name not avalilable in main function
+#' @param league_url league url from transfermarkt.com. To be used when country_name not available in main function
 #'
 #' @return returns a character vector of all transfermarkt team URLs for a selected league
 #'

diff --git a/cran-comments.md b/cran-comments.md
@@ -1,11 +1,14 @@
 ## Release summary
 
-This is a minor release that addressed some broken URL endpoints
+This is a re-submission.
+
+* Package `Title` and `Description` remove redundant text
+* Package now robust against internet access issues
 
 
 ## Test environments
-* local R installation, R 4.1.0
-* ubuntu 16.04 (on travis-ci), R 4.1.0
+* local R installation, R 4.2.0
+* ubuntu 20.04.4 (on GitHub Actions), R 4.2.0
 * win-builder (devel)
 
 ## R CMD check results

diff --git a/man/fotmob_get_season_stats.Rd b/man/fotmob_get_season_stats.Rd
diff --git a/man/tm_league_team_urls.Rd b/man/tm_league_team_urls.Rd
diff --git a/man/tm_matchday_table.Rd b/man/tm_matchday_table.Rd
diff --git a/man/tm_team_transfer_balances.Rd b/man/tm_team_transfer_balances.Rd
diff --git a/man/understat_league_season_shots.Rd b/man/understat_league_season_shots.Rd
diff --git a/vignettes/load-scraped-data.Rmd b/vignettes/load-scraped-data.Rmd
@@ -82,7 +82,7 @@ dplyr::glimpse(eng_match_results)
 ```
 
 
-## Load FBref big 5 league advanced seasdon stats
+## Load FBref big 5 league advanced season stats
 
 To load pre-scraped advanced stats for the big five European leagues for either teams or players, the `load_fb_big5_advanced_season_stats()` can be used. This data is scheduled to be updated most days and a print statement will inform the user of when the data was last updated.