Feature/tm absence #353
Merged
Feature/tm absence #353
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #353 +/- ##
==========================================
+ Coverage 64.79% 65.33% +0.53%
==========================================
Files 44 45 +1
Lines 3568 3623 +55
==========================================
+ Hits 2312 2367 +55
Misses 1256 1256 ☔ View full report in Codecov by Sentry. |
|
The new function 
and returns it as so in an R data frame: 
Happy with that @tonyelhabr? |
JaseZiv
commented
Jan 14, 2024
| @@ -297,7 +297,7 @@ dplyr::glimpse(hazard_injuries) | |||
| #----- for multiple players: -----# | |||
| # # can make use of a tm helper function: | |||
| # burnley_player_urls <- tm_team_player_urls(team_url = "https://www.transfermarkt.com/fc-burnley/startseite/verein/1132/saison_id/2021") | |||
| # # then pass all those URLs to the tm_player_bio | |||
| # # then pass all those URLs to the tm_player_injury_history | |||
tonyelhabr
approved these changes
Jan 14, 2024
Haha not a Spurs fan, but definitely a Big Ange fan (and also 'Romero' was the first name with suspensions that came to mind to type in transfermarkt's search bar)! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
addressing #352
Still need to update vignettes, run local check
EDIT: Now completed