Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix escaping JSON issues #407

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fix escaping JSON issues #407

wants to merge 2 commits into from

Conversation

mrala
Copy link
Contributor

@mrala mrala commented Jun 24, 2024

Description

Window titles with with escape sequences are not being parsed properly.

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Validated the following window titles are parsing and displaying correctly in simple-bar:

  • simple-bar
  • \simple-\\bar, previous error: SyntaxError: JSON Parse error: Invalid escape character s
  • \"simple-\bar\", previous error: SyntaxError: JSON Parse error: Expected '}'

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings

Changes to make to the documentation

n/a

@mrala
Fix escaping JSON issues.
a21de6c 
Signed-off-by: Ali Yahya <[email protected]>
@mrala
Formatting.
44087f9 
Signed-off-by: Ali Yahya <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

SyntaxError: JSON Parse error: Invalid escape character d
1 participant
@mrala