Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make sure we use a canonical name for all packages and references to packages in requirements #57

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

JeanChristopheMorinPerso
Copy link
Owner

@JeanChristopheMorinPerso JeanChristopheMorinPerso commented Oct 14, 2023

Fixes #55.

  • Add tests.
  • Document this package name conversion properly.
  • Add a big warning in the release notes since this is a breaking change.

@codecov
Copy link

codecov bot commented Oct 14, 2023

Codecov Report

Merging #57 (d14f3d3) into main (9c61a5d) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main      #57   +/-   ##
=======================================
  Coverage   77.57%   77.57%           
=======================================
  Files           8        8           
  Lines         709      709           
  Branches      147      147           
=======================================
  Hits          550      550           
  Misses        151      151           
  Partials        8        8           
Files Coverage Δ
src/rez_pip/utils.py 76.03% <100.00%> (ø)

…packages in requirements

Signed-off-by: Jean-Christophe Morin <[email protected]>
Signed-off-by: Jean-Christophe Morin <[email protected]>
Signed-off-by: Jean-Christophe Morin <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Package names inconsistent between requirements and installed packages
1 participant