Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update MacOS CFBundleVersion validation #4874

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -169,7 +169,7 @@ private object WindowsVersionChecker : VersionChecker {

private object MacVersionChecker : VersionChecker {
override val correctFormat = """|'MAJOR[.MINOR][.PATCH]', where:
| * MAJOR is an integer > 0;
| * MAJOR is a non-negative integer;
| * MINOR is an optional non-negative integer;
| * PATCH is an optional non-negative integer;
""".trimMargin()
Expand All @@ -180,6 +180,5 @@ private object MacVersionChecker : VersionChecker {
return parts.isNotEmpty()
&& parts.size <= 3
&& parts.all { it != null && it >= 0 }
&& (parts.first() ?: 0) > 0
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -191,7 +191,7 @@ compose.desktop {
Versions must follow the rules:
* For `dmg` and `pkg`:
* The format is `MAJOR[.MINOR][.PATCH]`, where:
* `MAJOR` is an integer > 0;
* `MAJOR` is a non-negative integer;
* `MINOR` is an optional non-negative integer;
* `PATCH` is an optional non-negative integer;
* For `msi` and `exe`:
Expand Down