Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add show function to spans #222

Merged
merged 14 commits into from
Jul 1, 2024
Merged

Add show function to spans #222

merged 14 commits into from
Jul 1, 2024

Conversation

Paalon
Copy link
Contributor

@Paalon Paalon commented Jun 20, 2024

Depends on #183. Add a show function to Span for debugging.
Shown as the following format:

(line, column) ∈ (10, 20)...(20, 10)

@Paalon Paalon mentioned this pull request Jun 22, 2024
@kescobo
Copy link
Collaborator

kescobo commented Jun 25, 2024

#183 now merged - resolve conflicts and we can merge this too.

Copy link

codecov bot commented Jun 29, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 87.20%. Comparing base (3b2b353) to head (505b204).

Files Patch % Lines
src/span.jl 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master     #222   +/-   ##
=======================================
  Coverage   87.19%   87.20%           
=======================================
  Files          15       15           
  Lines        1664     1665    +1     
=======================================
+ Hits         1451     1452    +1     
  Misses        213      213           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Paalon
Copy link
Contributor Author

Paalon commented Jun 29, 2024

Now, conflicts are resolved.

@kescobo kescobo merged commit a440b9a into JuliaData:master Jul 1, 2024
21 of 22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants