Revert eol attributes #234
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 2daef25.
…er files. Revise an in-memory test of JuliaData#132 to actually test windows newlines. Add back revision of windows_newlines.yaml.
kescobo
approved these changes
Jun 28, 2024
|
Thank you for handling this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First commit reverts all of #218 (it was inconvenient to separate #217 since they had been squashed).
Second commit adds back test files for issue #132 but revised to run with the ordinary file tests. It also revises the test I earlier added for the same issue to actually test windows newlines 🤦 and brings back the revision of the
windows_newlines.yamlfile from #218.Fixes #232.
Note: I think it would be clearer to merge this PR without squashing the two commits.