Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TetGen: patch upstream to fix crash #3611

Merged
merged 1 commit into from
Sep 13, 2021

Conversation

j-fu
Copy link
Contributor

@j-fu j-fu commented Sep 10, 2021

No description provided.

@j-fu j-fu changed the title patch upstream to fix crash TetGen: patch upstream to fix crash Sep 11, 2021
# the previous 1.5 version this does not happen.
#
mv tetgen.cxx tmp.cxx
sed -e "s/tetrahedrons->items \* 10/(tetrahedrons->items + 100) * 10/g" tmp.cxx > tetgen.cxx
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there an upstream PR?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Upstream situtation is a little bit nonstandard. The UFZ repo referred to in the script is a github version of the upstream source available as download from tetgen.org (hosted at wias-berlin.de) after filling a download form. This is for historical reasons when open source was seen with suspicion etc., I am personally involved into this almost from beginning...

So I could send this as a PR to "semi-upstream" at UFZ, but the also prefer to keep it "as is":
ufz/tetgen#1 (comment) , so I decided for this PR.

The optimal course of action would start with having an official upstream repo. I will try to fix this situation at wias-berlin.de, which hopefully can be resolved in a couple of weeks. If this works I would let the UFZ people know and try to set up a proper workflow with the author Hang Si and modify the script accordingly.

Meanwhile I propose to accept this PR as a short-time solution.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That is.... hilariously German.

@vchuravy vchuravy merged commit 304385b into JuliaPackaging:master Sep 13, 2021
@j-fu j-fu deleted the fix_tetgen_readme branch October 7, 2021 15:55
simeonschaub pushed a commit to simeonschaub/Yggdrasil that referenced this pull request Feb 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants