Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New package: LSurvival v1.1.0 #91198

Conversation

JuliaRegistrator
Copy link
Contributor

UUID: edbbf5c1-874b-40a5-8c9f-d8fc918aacaa
Repo: https://github.com/alexpkeil1/LSurvival.jl.git
Tree: 0fbb6a919e23aea6c09fb59acf62643fb8765f1d

Registrator tree SHA: f73a20c99934db92a256057d0d83ba394036a701
@github-actions
Copy link
Contributor

Your new package pull request does not meet the guidelines for auto-merging. Please make sure that you have read the General registry README and the AutoMerge guidelines. The following guidelines were not met:

  • Package name similar to 1 existing package.
    1. Similar to Survival. Damerau-Levenshtein distance 1 is at or below cutoff of 2. Damerau-Levenshtein distance 1 between lowercased names is at or below cutoff of 1.

Note that the guidelines are only required for the pull request to be merged automatically. However, it is strongly recommended to follow them, since otherwise the pull request needs to be manually reviewed and merged by a human.

After you have fixed the AutoMerge issues, simple retrigger Registrator, which will automatically update this pull request. You do not need to change the version number in your Project.toml file (unless of course the AutoMerge issue is that you skipped a version number, in which case you should change the version number).

If you do not want to fix the AutoMerge issues, please post a comment explaining why you would like this pull request to be manually merged. Then, send a message to the #pkg-registration channel in the Julia Slack to ask for help. Include a link to this pull request.

Since you are registering a new package, please make sure that you have also read the package naming guidelines: https://julialang.github.io/Pkg.jl/dev/creating-packages/#Package-naming-guidelines-1


If you want to prevent this pull request from being auto-merged, simply leave a comment. If you want to post a comment without blocking auto-merging, you must include the text [noblock] in your comment. You can edit blocking comments, adding [noblock] to them in order to unblock auto-merging.

@alexpkeil1
Copy link

[noblock] Resubmission after changing module name from LSurv to LSurvival following this: #91190 (comment)

I am requesting a manual merge to over-ride automerge, which fails due to the similarity between "Survival" and "LSurvival." This re-factors some of the capabilities of "Survival.jl" in a way that wouldn't be easily done through modifications to that package. It generalizes the capabilities to much more realistic settings for survival data analysis and so provides unique capabilities for survival analysis in Julia. The confusion between "LSurvival" and "Survival" seems unlikely and the "L" emphasizes functionality for "Left truncation," but "LeftTruncationSurvival" or simpler iterations are cumbersome and suggest limited utility.

@github-actions
Copy link
Contributor

This pull request has been inactive for 30 days and will be automatically closed 7 days from now. If this pull request should not be closed, please either (1) fix the AutoMerge issues and re-trigger Registrator, which will automatically update the pull request, or (2) post a comment explaining why you would like this pull request to be manually merged. [noblock]

@github-actions github-actions bot added the stale label Oct 12, 2023
@alexpkeil1
Copy link

[noblock] I have already requested this to be manually merged via the recommended slack channel (https://julialang.slack.com/archives/C6M4DQA5P/p1694448732309659) but have received no response via slack nor any apparent action on github. This package now includes parametric, non-parametric, and semi-parametric approaches to survival analysis that allow left truncation and right censoring and thus is more comprehensive and up-to-date than any of the alternative packages that were mentioned in this thread: #91190 (comment)

The only other package that seems to handle left truncation is https://github.com/kkholst/EventHistory.jl, which was last updated 6 years ago.
The only response I recieved via my previous attempt at registering the module was that I should be updating the other modules, but at this point the LSurvival module has surpassed the capabilities of anything existing, so it would require unnecessarily re-duplicating my own efforts on other modules. The only usable survival analysis module in the general registry that I'm aware of is Survival.jl from juliastats, which cannot be easily modified via pull requests to incorporate left truncation because the estimation algorithms in that module rely on shortcuts that only work if left truncation is not allowed. Trying to adapt that module to be as general as LSurvival.jl would require a complete refactorization of that module. I'm happy for someone from JuliaStats to take what I've done and incorporate it into Survival.jl, but I am not in a position to do that myself. Survival.jl is fast, but it isn't suited for very many applied problems, which is why I wrote LSurvival.jl. The functions in LSurvival.jl have been validated, where possible, against the survival package in R, which is the gold standard in applied survival analysis.

@github-actions github-actions bot removed the stale label Oct 13, 2023
Copy link
Contributor

This pull request has been inactive for 30 days and will be automatically closed 7 days from now. If this pull request should not be closed, please either (1) fix the AutoMerge issues and re-trigger Registrator, which will automatically update the pull request, or (2) post a comment explaining why you would like this pull request to be manually merged. [noblock]

@github-actions github-actions bot added the stale label Nov 13, 2023
Copy link
Contributor

This pull request has been inactive for more than 30 days and has automatically been closed. Feel free to register your package or version again once you fix the AutoMerge issues. [noblock]

@github-actions github-actions bot closed this Nov 20, 2023
@github-actions github-actions bot deleted the registrator-lsurvival-edbbf5c1-v1.1.0-24b11deed0 branch November 20, 2023 12:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants