Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nosrati diagonal quasi Newton update #283

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

MohamedLaghdafHABIBOULLAH

No description provided.

@dpo dpo requested a review from geoffroyleconte July 11, 2023 22:57
@dpo
Copy link
Member

dpo commented Jul 11, 2023

After this PR, I think we need to separate the updates into different types and implement push!() for each type. That will be more powerful than a large if … else … end.

@codecov
Copy link

codecov bot commented Jul 11, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.58%. Comparing base (55e0273) to head (05ff34a).
Report is 17 commits behind head on main.

❗ Current head 05ff34a differs from pull request most recent head e121c19. Consider uploading reports for the commit e121c19 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #283   +/-   ##
=======================================
  Coverage   96.57%   96.58%           
=======================================
  Files          15       15           
  Lines        1052     1055    +3     
=======================================
+ Hits         1016     1019    +3     
  Misses         36       36           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions
Copy link
Contributor

Package name latest stable
CaNNOLeS.jl
DCISolver.jl
FletcherPenaltySolver.jl
JSOSolvers.jl
Krylov.jl
NLPModels.jl
NLPModelsModifiers.jl
PROPACK.jl
Percival.jl
QuadraticModels.jl
SolverTools.jl

@tmigot
Copy link
Member

tmigot commented Feb 16, 2024

Hey guys! Is there something blocking here?

@dpo
Copy link
Member

dpo commented Feb 25, 2024

Yes. This should be reworked after #316 has been merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants