Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added baseline statistics for Cox #9

Closed
wants to merge 3 commits into from
Closed

Added baseline statistics for Cox #9

wants to merge 3 commits into from

Conversation

piever
Copy link
Contributor

@piever piever commented Dec 19, 2017

This is part 4 of #5 . I've added three functions to get baseline hazard, cumulative hazard and survival functions of a fitted CoxModel and added some docs.

@piever
Copy link
Contributor Author

piever commented Dec 19, 2017

I'm not sure what should baseline_survival (and similar) return: now it gives a pair of vectors (times and values), but maybe it should give a function that can be tested on any new value, like ecdf? Or maybe even both and we could create new type that has both x and y fields (with these vectors) but is also callable. What do you think?

@nalimilan
Copy link
Member

I agree it makes sense to return a special distribution object. I think there have been discussions about how to represent empirical distributions in the same framework as the Distributions packages. @andreasnoack knows better.

@piever
Copy link
Contributor Author

piever commented Dec 19, 2017

That'd be very helpful. I should probably leave as is here for now and maybe we can open an issue about this at StatsBase (where I think this kind of object should be defined)? I think the new type should have x and y field for the specific points, a f field with the function and potentially a few constructors to simplify building f in the common cases.

@nalimilan
Copy link
Member

I guess the type would be defined in this package, but it could inherit from and implement an abstract type defined e.g. in Distributions.

@ararslan ararslan deleted the branch JuliaStats:master July 19, 2022 02:26
@ararslan ararslan closed this Jul 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants