Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Grammar #112

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Grammar #112

wants to merge 2 commits into from

Conversation

PallHaraldsson
Copy link
Contributor

[skip ci]

[skip ci]
@PallHaraldsson
Copy link
Contributor Author

PallHaraldsson commented Apr 9, 2019

It was driving me crazy, is "an UTF-8 version of a string" correct ("an U[niversial]TF") or better with "a" for "a [..] version" or "a [..] string"?

I do see "an UTF-8 BOM" at UTF-8 Wikipedia article, but it's also inconsistent, and you using "an ASCII string".

@PallHaraldsson
Copy link
Contributor Author

PallHaraldsson commented Apr 9, 2019

@ScottPJones
Copy link
Member

'a UTF-8' is correct. Whoever wrote that sentence in the Wiki article might not have been a native English speaker (or not a very good one).

@PallHaraldsson
Copy link
Contributor Author

'a UTF-8' is correct.

Thanks, I've now changed the PR to leave that unchanged. These are just minor changes you may want to commit. I'm not a native English speaker, and as I said started to get doubts. Not sure why CI failed, it's a false alarm...

@coveralls
Copy link

coveralls commented May 6, 2019

Pull Request Test Coverage Report for Build 512

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 0.0%

Totals Coverage Status
Change from base Build 509: 0.0%
Covered Lines: 0
Relevant Lines: 0

💛 - Coveralls

2 similar comments
@coveralls
Copy link

Pull Request Test Coverage Report for Build 512

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 0.0%

Totals Coverage Status
Change from base Build 509: 0.0%
Covered Lines: 0
Relevant Lines: 0

💛 - Coveralls

@coveralls
Copy link

Pull Request Test Coverage Report for Build 512

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 0.0%

Totals Coverage Status
Change from base Build 509: 0.0%
Covered Lines: 0
Relevant Lines: 0

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants