Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor key meta #995

Merged
merged 15 commits into from
Jul 1, 2024
Merged

Refactor key meta #995

merged 15 commits into from
Jul 1, 2024

Conversation

xs5871
Copy link
Collaborator

@xs5871 xs5871 commented Jun 30, 2024

As promised in #988:

Coming soon: getting rid of key.meta, aka: "we already use classes for key types, but only sometimes, and we hide it behind a layer of indirection".

All key.meta classes and attributes have been refactored into flat Key classes, plus some cleanup and code simplification.
Anecdotal performance improvement: my personal config uses ~2kB less RAM with these changes.

Copy link
Member

@regicidalplutophage regicidalplutophage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It even takes up less memory, nice!

@xs5871 xs5871 merged commit 1004dc6 into main Jul 1, 2024
3 checks passed
@xs5871 xs5871 deleted the refactor-key_meta branch July 1, 2024 20:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants