Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

added 2 diamond patterns #10

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

added 2 diamond patterns #10

wants to merge 1 commit into from

Conversation

Harshvg2021
Copy link

Closes #

📑 Description

Added a diamond pattern

✅ Checks

  • [ ✅] My pull request adheres to the code style of this project
  • [✅ ] My code requires changes to the documentation
  • [✅ ] I have updated the documentation as required
  • [✅ ] All the tests have passed

📝 Additional Information

@Kaur-mahar Kaur-mahar added documentation Improvements or additions to documentation enhancement New feature or request good first issue Good for newcomers hacktoberfest-accepted labels Oct 18, 2022
@Kaur-mahar
Copy link
Owner

I've added the label but your code is a little bit broken and hard coded.
If you fix that then I'll merge it.

@Harshvg2021
Copy link
Author

hello , could you please expand on what changes i must do ?
the codes seems to run perfectly fine, and also is not hardcoded as i am accepting values from user.

@Kaur-mahar
Copy link
Owner

Top of your diamonds

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
documentation Improvements or additions to documentation enhancement New feature or request good first issue Good for newcomers hacktoberfest-accepted
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Harshvg2021 @Kaur-mahar