Remove MongoDB connection options from log, to avoid credentials display

KeshavSoni2511 · Jul 5, 2023 · d676425 · d676425
1 parent 89cea3f
commit d676425
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 7 deletions.
diff --git a/CHANGES_NEXT_RELEASE b/CHANGES_NEXT_RELEASE
@@ -1 +1,2 @@
 - Fix: appendMode at general level (config.js / env var) changes its default from false to true
+- Fix: remove sensitive MongoDB connection parameters from log traces (remove 'option' object from logs)
diff --git a/lib/model/dbConn.js b/lib/model/dbConn.js
@@ -106,13 +106,7 @@ function init(host, db, port, options, callback) {
     }
 
     function connectionAttempt(url, options, callback) {
-        logger.info(
-            context,
-            'Attempting to connect to MongoDB instance with url %j and options %j. Attempt %d',
-            url,
-            options,
-            retries
-        );
+        logger.info(context, 'Attempting to connect to MongoDB instance with url %j. Attempt %d', url, retries);
         // FIXME: useNewUrlParser is no longer used in underlying mongodb driver 4.x
         // (see https://github.com/mongodb/node-mongodb-native/blob/HEAD/etc/notes/CHANGES_4.0.0.md)
         // but not sure if current mongoose version is still using mongodb 3.x internally