Merge pull request #3 from Keyfactor/readme

Update keyfactor-starter-workflow.yml
Keyfactor · Jun 3, 2022 · d4ed368 · d4ed368
2 parents c22968b + 7b63f6b
commit d4ed368
Show file tree

Hide file tree

Showing 4 changed files with 3 additions and 3 deletions.
diff --git a/.github/workflows/keyfactor-starter-workflow.yml b/.github/workflows/keyfactor-starter-workflow.yml
@@ -11,7 +11,7 @@ jobs:
     with:
       release_version: ${{ needs.call-create-github-release-workflow.outputs.release_version }}
       release_url: ${{ needs.call-create-github-release-workflow.outputs.release_url }}
-      release_dir: DataPower/bin/Release # TODO: set build output directory to upload as a release, relative to checkout workspace
+      release_dir: DataPower/bin/Debug # TODO: set build output directory to upload as a release, relative to checkout workspace
     secrets: 
       token: ${{ secrets.PRIVATE_PACKAGE_ACCESS }}
 

diff --git a/README.md b/README.md
@@ -37,7 +37,7 @@ Basic |Requires Store Password	|Determines if a store password is required when
 Basic |Supports Entry Password	|Determined if an individual entry within a store can have a password.  This must be unchecked.
 Advanced |Store Path Type| Determines how the user will enter the store path when setting up the cert store.  Freeform
 Advanced |Supports Custom Alias	|Determines if an individual entry within a store can have a custom Alias.  Optional (if left blank, alias will be a GUID)
-Advanced |Private Key Handling |Determines how the orchestrator deals with private keys.  Required
+Advanced |Private Key Handling |Determines how the orchestrator deals with private keys.  Optional
 Advanced |PFX Password Style |Determines password style for the PFX Password. Default
 Custom Fields|Inventory Page Size|Name:InventoryPageSize Display Name:Inventory Page Size Type:String Default Value:100 Required:True.  This determines the page size during the inventory calls. (100 should be fine)
 Custom Fields|Public Cert Store Name|Name:PublicCertStoreName Display Name:Public Cert Store Name:String Default Value:pubcert Required:True.  This probably will remain pubcert unless someone changed the default name in DataPower.

diff --git a/images/CertStoreType-Advanced.gif b/images/CertStoreType-Advanced.gif
diff --git a/readme_source.md b/readme_source.md
@@ -21,7 +21,7 @@ Basic |Requires Store Password	|Determines if a store password is required when
 Basic |Supports Entry Password	|Determined if an individual entry within a store can have a password.  This must be unchecked.
 Advanced |Store Path Type| Determines how the user will enter the store path when setting up the cert store.  Freeform
 Advanced |Supports Custom Alias	|Determines if an individual entry within a store can have a custom Alias.  Optional (if left blank, alias will be a GUID)
-Advanced |Private Key Handling |Determines how the orchestrator deals with private keys.  Required
+Advanced |Private Key Handling |Determines how the orchestrator deals with private keys.  Optional
 Advanced |PFX Password Style |Determines password style for the PFX Password. Default
 Custom Fields|Inventory Page Size|Name:InventoryPageSize Display Name:Inventory Page Size Type:String Default Value:100 Required:True.  This determines the page size during the inventory calls. (100 should be fine)
 Custom Fields|Public Cert Store Name|Name:PublicCertStoreName Display Name:Public Cert Store Name:String Default Value:pubcert Required:True.  This probably will remain pubcert unless someone changed the default name in DataPower.