Distribute ratelimiter requests across the cluster by route #621
Conversation
jchristgit
force-pushed
the
ratelimiter-phash2
branch
from
8093050
to
756e852
Compare
| `:erlang.phash2/2`. | ||
| """ | ||
|
|
||
| @scope_name __MODULE__ |
There was a problem hiding this comment.
Should we make this value configurable? Issues could theoretically arise if you were running multiple bots and had the nodes connected, you'd get 403s that were difficult to debug if you weren't aware of this module.
There was a problem hiding this comment.
We should make not the scope name but the group name configurable to set it to the bot ID that the ratelimiters run for.
Would running multiple bots with distinct configurations even work currently? I think you would run into other confusing bugs.
There was a problem hiding this comment.
I think for later we should make the group name configurable in the start_link function. For now I'm not sure we need to, because plenty of other things break. What do you think?
As described in #620, currently the ratelimiter is not usable across multiple nodes. Lay the groundwork for doing this by registering ratelimiters in a process group and selecting the matching ratelimiter based on the request route. Note that some minor further adjustments need to be made to make the ratelimiter fully functional over multiple nodes, primarily related to process registration, but some further documentation is also missing and will be amended once manual consumer startup is prepared.
jchristgit
force-pushed
the
ratelimiter-phash2
branch
from
756e852
to
7e43012
Compare
As described in #620, currently the ratelimiter is not usable across
multiple nodes. Lay the groundwork for doing this by registering
ratelimiters in a process group and selecting the matching ratelimiter
based on the request route.
Note that some minor further adjustments need to be made to make the
ratelimiter fully functional over multiple nodes, primarily related to
process registration, but some further documentation is also missing and
will be amended once manual consumer startup is prepared.