Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Core][TrilinosApplication] Defining list of fastest direct linear solvers. #12350

Merged

Conversation

loumalouomega
Copy link
Member

@loumalouomega loumalouomega commented May 6, 2024

馃摑 Description

Part of #12309, defining list of fastest direct linear solvers.

馃啎 Changelog

@loumalouomega loumalouomega added Kratos Core Applications Parallel-MPI Distributed memory parallelism for HPC / clusters FastPR This Pr is simple and / or has been already tested and the revision should be fast Transition labels May 6, 2024
@loumalouomega loumalouomega requested review from a team as code owners May 6, 2024 13:19
@loumalouomega loumalouomega changed the title [Core][TrilinosApplication] Defning list of fastest direct linear solvers. [Core][TrilinosApplication] Defining list of fastest direct linear solvers. May 6, 2024
@philbucher
Copy link
Member

I think this is a good addition

Can you please expose and use it in the python level to avoid code duplication?

@loumalouomega
Copy link
Member Author

I think this is a good addition

Can you please expose and use it in the python level to avoid code duplication?

Done


namespace Kratos::Python
{
void AddSpaceToPython(pybind11::module& m)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am 99% sure this exists already somewhere

Probably in the addstrategiestopython

Having it separate makes sense but not duplicated

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A priori it is not, at least I couldn't find it. UblasSpace is old...

Copy link
Member Author

@loumalouomega loumalouomega May 7, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay I found it, name is UblasSparseSpace

Copy link
Member

@philbucher philbucher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@loumalouomega loumalouomega merged commit e85a583 into master May 7, 2024
11 checks passed
@loumalouomega loumalouomega deleted the core/define-list-fastest-direct-linear-solvers branch May 7, 2024 08:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Applications FastPR This Pr is simple and / or has been already tested and the revision should be fast Kratos Core Parallel-MPI Distributed memory parallelism for HPC / clusters Transition
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants