Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: restore workflow pipeline, fix some problems of lint and ut #436

Merged
merged 22 commits into from
May 22, 2024

Conversation

elliotxx
Copy link
Collaborator

@elliotxx elliotxx commented May 20, 2024

What type of PR is this?

/kind ci

What this PR does / why we need it:

  • Restore workflow pipeline.
  • Fix some problems of lint, unit tests.
  • Debug golangci-lint problems:
Running error: can't run linter goanalysis_metalinter\nbuildssa: failed to load package main: could not load export data: no export data for \"k8s.io/kube-aggregator\"

@elliotxx elliotxx added this to the v0.4.0 milestone May 20, 2024
@elliotxx elliotxx self-assigned this May 20, 2024
@elliotxx elliotxx force-pushed the restore-ci-pipeline branch 2 times, most recently from a86d3c3 to f962e0c Compare May 22, 2024 07:29
@elliotxx elliotxx changed the title ci: restore ci pipeline ci: restore workflow pipeline May 22, 2024
@elliotxx elliotxx enabled auto-merge (squash) May 22, 2024 13:57
@elliotxx elliotxx changed the title ci: restore workflow pipeline ci: restore workflow pipeline, fix some problems of lint, ut May 22, 2024
@elliotxx elliotxx changed the title ci: restore workflow pipeline, fix some problems of lint, ut ci: restore workflow pipeline, fix some problems of lint and ut May 22, 2024
Copy link
Collaborator

@adohe adohe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@elliotxx elliotxx merged commit ca5da5f into main May 22, 2024
16 checks passed
@elliotxx elliotxx deleted the restore-ci-pipeline branch May 22, 2024 14:00
@github-actions github-actions bot locked and limited conversation to collaborators May 22, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants