Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: support cluster install #86

Merged
merged 2 commits into from
Dec 4, 2023
Merged

feat: support cluster install #86

merged 2 commits into from
Dec 4, 2023

Conversation

panshuai-ps
Copy link
Collaborator

What type of PR is this?

/kind feature

What this PR does / why we need it:

support cluster install

This was linked to issues Nov 30, 2023
Cluster Management: Add cluster health check #51
Closed
Cluster Management: Generate Cluster CR from user input #81
Closed
ffforest
ffforest approved these changes Dec 4, 2023
View reviewed changes
Copy link
Collaborator

@ffforest ffforest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ffforest ffforest merged commit 921bdd7 into main Dec 4, 2023
7 checks passed
@ffforest ffforest deleted the cluster-install branch December 4, 2023 08:33
@github-actions github-actions bot locked and limited conversation to collaborators Dec 4, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ffforest ffforest ffforest approved these changes

@elliotxx elliotxx Awaiting requested review from elliotxx elliotxx is a code owner

@adohe adohe Awaiting requested review from adohe adohe is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Cluster Management: Generate Cluster CR from user input Cluster Management: Add cluster health check
2 participants
@panshuai-ps @ffforest