Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: init web framework implement #88

Merged
merged 6 commits into from
Dec 5, 2023
Merged

feat: init web framework implement #88

merged 6 commits into from
Dec 5, 2023

Conversation

elliotxx
Copy link
Collaborator

@elliotxx elliotxx commented Nov 28, 2023 •
edited
Loading

What type of PR is this?

/kind feature

What this PR does / why we need it:

Implement a web framework, including:

  • Automatically inject requestID, auditLogger, bizLogger
  • Support automatic recovery when api call panic
  • 100% compatible with standard library(net/http)
  • Except for go-chi/chi, there is no indirect dependence

@elliotxx elliotxx self-assigned this Nov 28, 2023
@elliotxx elliotxx requested a review from adohe as a code owner November 28, 2023 16:19
@elliotxx elliotxx changed the title feat: init web framework implement [WIP] feat: init web framework implement Nov 29, 2023
@elliotxx elliotxx added the enhancement New feature or request label Nov 29, 2023
@elliotxx elliotxx added this to the v0.3.0 milestone Nov 29, 2023
@ffforest ffforest linked an issue Dec 4, 2023 that may be closed by this pull request
Logistics: Integrate with a lightweight web server framework #91
Closed
@elliotxx elliotxx changed the title [WIP] feat: init web framework implement feat: init web framework implement Dec 4, 2023
@elliotxx elliotxx enabled auto-merge (squash) December 4, 2023 15:02
ffforest
ffforest approved these changes Dec 5, 2023
View reviewed changes
Copy link
Collaborator

@ffforest ffforest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@elliotxx elliotxx merged commit 0724684 into main Dec 5, 2023
12 of 13 checks passed
@elliotxx elliotxx deleted the init-web-framework-implement branch December 5, 2023 02:39
@github-actions github-actions bot locked and limited conversation to collaborators Dec 5, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ffforest ffforest ffforest approved these changes

@panshuai-ps panshuai-ps Awaiting requested review from panshuai-ps panshuai-ps is a code owner

@adohe adohe Awaiting requested review from adohe adohe is a code owner

Assignees

@elliotxx elliotxx

Labels
enhancement New feature or request
Projects
None yet
Milestone
v0.3.0
Development

Successfully merging this pull request may close these issues.

Logistics: Integrate with a lightweight web server framework
2 participants
@elliotxx @ffforest