Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding field axis opts + detrending for the vsd #74

Merged
merged 1 commit into from
Jul 4, 2024
Merged

Conversation

LemurPwned
Copy link
Owner

@LemurPwned LemurPwned commented Jul 4, 2024

Summary by Sourcery

This pull request introduces new axis options ('xy', 'xz', 'yz') for external field selection, updates the excitation input range for better precision, and adds detrending functionality for the VSD spectrum.

  • New Features:
    • Added support for new axis options ('xy', 'xz', 'yz') in the external field selection.
  • Enhancements:
    • Updated the excitation input range in the Streamlit app from kA/m to A/m for better precision.
    • Integrated detrending functionality for the VSD spectrum using the Filters utility.

Copy link

sourcery-ai bot commented Jul 4, 2024

Reviewer's Guide by Sourcery

This pull request introduces new axis options ('xy', 'xz', 'yz') for field control in the VSD simulation, updates the frontend to support these new options, and enhances the VSD simulation by applying detrending to the spectrum data.

File-Level Changes

Files Changes
view/simulation_fns.py
view/streamlit_app.py
Added support for new axis options ('xy', 'xz', 'yz') in both the backend (simulation_fns.py) and frontend (streamlit_app.py).
view/helpers.py Updated VSD simulation to include detrending and removed unnecessary unit conversion for Hoex_mag.

Tips
  • Trigger a new Sourcery review by commenting @sourcery-ai review on the pull request.
  • Continue your discussion with Sourcery by replying directly to review comments.
  • You can change your review settings at any time by accessing your dashboard:
    • Enable or disable the Sourcery-generated pull request summary or reviewer's guide;
    • Change the review language;
  • You can always contact us if you have any questions or feedback.

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @LemurPwned - I've reviewed your changes and they look great!

Here's what I looked at during the review
  • 🟡 General issues: 2 issues found
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment to tell me if it was helpful.

view/simulation_fns.py Show resolved Hide resolved
view/helpers.py Show resolved Hide resolved
@LemurPwned LemurPwned merged commit d54309c into master Jul 4, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant