Adding ability to compress data when delivering to firehose #171
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jgrantr
previously approved these changes
Feb 16, 2023
| @@ -765,7 +765,7 @@ module.exports = function(configure) { | |||
| logger.time("firehose request"); | |||
| firehose.putRecordBatch({ | |||
| Records: [{ | |||
| Data: records.join('') | |||
| Data: opts.gzipFirehose ? (records.map(r => r.toString("base64")).join('\n') + '\n') : records.join('') | |||
There was a problem hiding this comment.
@czirker Are we expecting the person using this to be gzipping the content themselves?
| @@ -849,13 +849,13 @@ module.exports = function(configure) { | |||
| enableLogging: true, | |||
| snapshot: opts.snapshot | |||
| }, opts.chunk || {}); | |||
| chunkOpts.gzip = !opts.firehose; | |||
| chunkOpts.gzip = opts.gzipFirehose || !opts.firehose; | |||
There was a problem hiding this comment.
@czirker Or is that what this does? The chunker does the gzipping?
There was a problem hiding this comment.
Correct. The chunker will do the zipping. The user just needs to specify that they want to enable the feature using gzipFirehose:true
jgrantr
previously approved these changes
Jan 9, 2024
scotthawker
approved these changes
Jan 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should not be merged until the bus portion has be released. Otherwise it will send events that can't be processed in firehose