Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Beginning of an S3 experiment #117

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

rstorey
Copy link
Member

@rstorey rstorey commented Nov 2, 2018

No description provided.

@acdha
Copy link
Member

acdha commented Nov 5, 2018

As a general comment, I'm not a fan of having large if: blocks since they make it easier to miss bugs or inconsistent behaviour. The approach I've had in mind is basically to create a storage class which would support file enumeration, creation, etc. with a default local filesystem implementation and an optional S3 implementation so we could unit-test just that class and have a single code path through the main file.

This would also work nicely with optional dependencies: pip install bagit would get the traditional bagit.py but pip install bagit[s3] would pull in boto3 as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants