Skip to content

Playitgg integration #82

Playitgg integration

Playitgg integration #82

Triggered via pull request January 22, 2024 00:57
Status Success
Total duration 5m 35s
Artifacts

pr.yml

on: pull_request
Matrix: core-cargo-test / core-cargo-test
workspace-check  /  workspace-check
2m 31s
workspace-check / workspace-check
Matrix: core-build-and-draft / core-build-and-draft
Waiting for pending jobs
Matrix: dashboard-build-and-draft / dashboard-build-and-draft
Waiting for pending jobs
Fit to window
Zoom out
Zoom in

Annotations

63 warnings
core-cargo-test / core-cargo-test (ubuntu-latest, x86_64-unknown-linux-gnu)
The following actions uses node12 which is deprecated and will be forced to run on node16: actions-rs/toolchain@v1, actions-rs/cargo@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
core-cargo-test / core-cargo-test (ubuntu-latest, x86_64-unknown-linux-gnu)
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
core-cargo-test / core-cargo-test (ubuntu-latest, x86_64-unknown-linux-gnu)
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
core-cargo-test / core-cargo-test (ubuntu-latest, x86_64-unknown-linux-gnu)
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
core-cargo-test / core-cargo-test (ubuntu-latest, x86_64-unknown-linux-gnu)
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
core-cargo-test / core-cargo-test (ubuntu-latest, x86_64-unknown-linux-gnu)
failed to parse serde attribute
core-cargo-test / core-cargo-test (ubuntu-latest, x86_64-unknown-linux-gnu)
failed to parse serde attribute
core-cargo-test / core-cargo-test (ubuntu-latest, x86_64-unknown-linux-gnu)
failed to parse serde attribute
core-cargo-test / core-cargo-test (ubuntu-latest, x86_64-unknown-linux-gnu)
failed to parse serde attribute
core-cargo-test / core-cargo-test (ubuntu-latest, x86_64-unknown-linux-gnu)
failed to parse serde attribute
core-cargo-test / core-cargo-test (ubuntu-latest, x86_64-unknown-linux-gnu)
failed to parse serde attribute
core-cargo-test / core-cargo-test (ubuntu-latest, x86_64-unknown-linux-gnu)
failed to parse serde attribute
core-cargo-test / core-cargo-test (ubuntu-latest, x86_64-unknown-linux-gnu)
failed to parse serde attribute
core-cargo-test / core-cargo-test (ubuntu-latest, x86_64-unknown-linux-gnu)
failed to parse serde attribute
core-cargo-test / core-cargo-test (ubuntu-latest, x86_64-unknown-linux-gnu)
failed to parse serde attribute
you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let`: dashboard/src-tauri/src/main.rs#L117
warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` --> dashboard/src-tauri/src/main.rs:117:34 | 117 | .on_window_event(|event| match event.event() { | __________________________________^ 118 | | tauri::WindowEvent::CloseRequested { api, .. } => { 119 | | event.window().hide().unwrap(); 120 | | api.prevent_close(); 121 | | } 122 | | _ => {} 123 | | }) | |_________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match = note: `#[warn(clippy::single_match)]` on by default help: try this | 117 ~ .on_window_event(|event| if let tauri::WindowEvent::CloseRequested { api, .. } = event.event() { 118 + event.window().hide().unwrap(); 119 + api.prevent_close(); 120 ~ }) |
this function has too many arguments (8/7): core/src/traits/t_configurable/manifest.rs#L360
warning: this function has too many arguments (8/7) --> core/src/traits/t_configurable/manifest.rs:360:5 | 360 | / pub fn new_value_with_type( 361 | | setting_id: String, 362 | | name: String, 363 | | description: String, ... | 368 | | is_mutable: bool, 369 | | ) -> Self { | |_____________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments
this function has too many arguments (8/7): core/src/traits/t_configurable/manifest.rs#L332
warning: this function has too many arguments (8/7) --> core/src/traits/t_configurable/manifest.rs:332:5 | 332 | / pub fn new_optional_value( 333 | | setting_id: String, 334 | | name: String, 335 | | description: String, ... | 340 | | is_mutable: bool, 341 | | ) -> Self { | |_____________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments = note: `#[warn(clippy::too_many_arguments)]` on by default
the loop variable `i` is only used to index `tunnels`: core/src/playitgg/mod.rs#L351
warning: the loop variable `i` is only used to index `tunnels` --> core/src/playitgg/mod.rs:351:26 | 351 | for i in 0..tunnels.len() { | ^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop = note: `#[warn(clippy::needless_range_loop)]` on by default help: consider using an iterator | 351 | for <item> in &tunnels { | ~~~~~~ ~~~~~~~~
unnecessary closure used to substitute value for `Option::None`: core/src/macro_executor.rs#L1210
warning: unnecessary closure used to substitute value for `Option::None` --> core/src/macro_executor.rs:1210:9 | 1210 | / deno_runtime::errors::get_error_class_name(e) 1211 | | .or_else(|| { 1212 | | e.downcast_ref::<ImportMapError>() 1213 | | .map(get_import_map_error_class) ... | 1223 | | }) 1224 | | .unwrap_or_else(|| "Error") | |______________-------------------------^ | | | help: use `unwrap_or(..)` instead: `unwrap_or("Error")` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_lazy_evaluations = note: `#[warn(clippy::unnecessary_lazy_evaluations)]` on by default
struct `Resource` is never constructed: core/src/traits/t_resource.rs#L14
warning: struct `Resource` is never constructed --> core/src/traits/t_resource.rs:14:12 | 14 | pub struct Resource<T> | ^^^^^^^^
enum `ResourceType` is never used: core/src/traits/t_resource.rs#L6
warning: enum `ResourceType` is never used --> core/src/traits/t_resource.rs:6:10 | 6 | pub enum ResourceType { | ^^^^^^^^^^^^
method `allocate` is never used: core/src/port_manager.rs#L23
warning: method `allocate` is never used --> core/src/port_manager.rs:23:12 | 18 | impl PortManager { | ---------------- method in this implementation ... 23 | pub fn allocate(&mut self, start_port: u32) -> u32 { | ^^^^^^^^
field `channel_table` is never read: core/src/macro_executor.rs#L222
warning: field `channel_table` is never read --> core/src/macro_executor.rs:222:5 | 219 | pub struct MacroExecutor { | ------------- field in this struct ... 222 | channel_table: | ^^^^^^^^^^^^^ | = note: `MacroExecutor` has derived impls for the traits `Debug` and `Clone`, but these are intentionally ignored during dead code analysis
method `to_line` is never used: core/src/implementations/minecraft/configurable.rs#L1883
warning: method `to_line` is never used --> core/src/implementations/minecraft/configurable.rs:1883:12 | 1416 | impl ServerPropertySetting { | -------------------------- method in this implementation ... 1883 | pub fn to_line(&self) -> String { | ^^^^^^^
associated function `from_key_val` is never used: core/src/implementations/minecraft/configurable.rs#L313
warning: associated function `from_key_val` is never used --> core/src/implementations/minecraft/configurable.rs:313:12 | 281 | impl CmdArgSetting { | ------------------ associated function in this implementation ... 313 | pub fn from_key_val(key: &str, val: &str) -> Result<Self, Error> { | ^^^^^^^^^^^^
associated items `get_identifier`, `get_name`, `get_description`, and `from_key_val` are never used: core/src/implementations/minecraft/configurable.rs#L207
warning: associated items `get_identifier`, `get_name`, `get_description`, and `from_key_val` are never used --> core/src/implementations/minecraft/configurable.rs:207:12 | 206 | impl InstanceSetting { | -------------------- associated items in this implementation 207 | pub fn get_identifier(&self) -> String { | ^^^^^^^^^^^^^^ ... 213 | pub fn get_name(&self) -> String { | ^^^^^^^^ ... 219 | pub fn get_description(&self) -> String { | ^^^^^^^^^^^^^^^ ... 225 | pub fn from_key_val(key: &str, value: &str) -> Result<Self, Error> { | ^^^^^^^^^^^^
fields `path_to_resources`, `restart_on_crash`, and `backup_period` are never read: core/src/implementations/minecraft/mod.rs#L187
warning: fields `path_to_resources`, `restart_on_crash`, and `backup_period` are never read --> core/src/implementations/minecraft/mod.rs:187:5 | 174 | pub struct MinecraftInstance { | ----------------- fields in this struct ... 187 | path_to_resources: PathBuf, | ^^^^^^^^^^^^^^^^^ ... 192 | restart_on_crash: Arc<AtomicBool>, | ^^^^^^^^^^^^^^^^ 193 | backup_period: Option<u32>, | ^^^^^^^^^^^^^ | = note: `MinecraftInstance` has a derived impl for the trait `Clone`, but this is intentionally ignored during dead code analysis
field `procedure_call_kind` is never read: core/src/implementations/generic/bridge/procedure_call.rs#L337
warning: field `procedure_call_kind` is never read --> core/src/implementations/generic/bridge/procedure_call.rs:337:5 | 334 | pub struct ProcedureCallResultIR { | --------------------- field in this struct ... 337 | procedure_call_kind: ProcedureCallKind, | ^^^^^^^^^^^^^^^^^^^ | = note: `ProcedureCallResultIR` has derived impls for the traits `Clone` and `Debug`, but these are intentionally ignored during dead code analysis
fields `event_broadcaster`, `core_macro_executor`, `core_macro_pid`, and `drop_guard` are never read: core/src/implementations/generic/mod.rs#L39
warning: fields `event_broadcaster`, `core_macro_executor`, `core_macro_pid`, and `drop_guard` are never read --> core/src/implementations/generic/mod.rs:39:5 | 37 | pub struct GenericInstance { | --------------- fields in this struct 38 | dot_lodestone_config: DotLodestoneConfig, 39 | event_broadcaster: EventBroadcaster, | ^^^^^^^^^^^^^^^^^ 40 | procedure_bridge: bridge::procedure_call::ProcedureBridge, 41 | core_macro_executor: MacroExecutor, | ^^^^^^^^^^^^^^^^^^^ 42 | path: PathBuf, 43 | core_macro_pid: MacroPID, | ^^^^^^^^^^^^^^ 44 | drop_guard: Arc<GenericDropGuard>, | ^^^^^^^^^^ | = note: `GenericInstance` has a derived impl for the trait `Clone`, but this is intentionally ignored during dead code analysis = note: `#[warn(dead_code)]` on by default
unused variable: `procedure_result_rx`: core/src/implementations/generic/bridge/procedure_call.rs#L393
warning: unused variable: `procedure_result_rx` --> core/src/implementations/generic/bridge/procedure_call.rs:393:35 | 393 | let (procedure_result_tx, procedure_result_rx) = tokio::sync::broadcast::channel(256); | ^^^^^^^^^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_procedure_result_rx`
unused variable: `rx`: core/src/implementations/generic/bridge/procedure_call.rs#L372
warning: unused variable: `rx` --> core/src/implementations/generic/bridge/procedure_call.rs:372:9 | 372 | let rx = bridge.procedure_result_tx.subscribe(); | ^^ help: if this is intentional, prefix it with an underscore: `_rx` | = note: `#[warn(unused_variables)]` on by default
unused import: `futures_util::TryFutureExt`: core/src/lib.rs#L40
warning: unused import: `futures_util::TryFutureExt` --> core/src/lib.rs:40:5 | 40 | use futures_util::TryFutureExt; | ^^^^^^^^^^^^^^^^^^^^^^^^^^
unused import: `crate::types::LodestoneMetadata`: core/src/util.rs#L27
warning: unused import: `crate::types::LodestoneMetadata` --> core/src/util.rs:27:5 | 27 | use crate::types::LodestoneMetadata; | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
unused import: `lodestone_path`: core/src/util.rs#L26
warning: unused import: `lodestone_path` --> core/src/util.rs:26:35 | 26 | use crate::prelude::{path_to_tmp, lodestone_path}; | ^^^^^^^^^^^^^^
unused import: `ErrorKind`: core/src/util.rs#L25
warning: unused import: `ErrorKind` --> core/src/util.rs:25:27 | 25 | use crate::error::{Error, ErrorKind}; | ^^^^^^^^^
unused imports: `BuildMetadata`, `Prerelease`: core/src/prelude.rs#L5
warning: unused imports: `BuildMetadata`, `Prerelease` --> core/src/prelude.rs:5:14 | 5 | use semver::{BuildMetadata, Prerelease}; | ^^^^^^^^^^^^^ ^^^^^^^^^^
unused import: `debug`: core/src/implementations/generic/bridge/procedure_call.rs#L14
warning: unused import: `debug` --> core/src/implementations/generic/bridge/procedure_call.rs:14:15 | 14 | use tracing::{debug, error}; | ^^^^^ | = note: `#[warn(unused_imports)]` on by default
workspace-check / workspace-check
The following actions uses node12 which is deprecated and will be forced to run on node16: actions-rs/toolchain@v1, actions-rs/clippy-check@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
workspace-check / workspace-check
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
workspace-check / workspace-check
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
workspace-check / workspace-check
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
workspace-check / workspace-check
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
core-cargo-test / core-cargo-test (windows-latest, x86_64-pc-windows-msvc)
The following actions uses node12 which is deprecated and will be forced to run on node16: actions-rs/toolchain@v1, actions-rs/cargo@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
core-cargo-test / core-cargo-test (windows-latest, x86_64-pc-windows-msvc)
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
core-cargo-test / core-cargo-test (windows-latest, x86_64-pc-windows-msvc)
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
core-cargo-test / core-cargo-test (windows-latest, x86_64-pc-windows-msvc)
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
core-cargo-test / core-cargo-test (windows-latest, x86_64-pc-windows-msvc)
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
core-cargo-test / core-cargo-test (macos-latest, x86_64-apple-darwin)
The following actions uses node12 which is deprecated and will be forced to run on node16: actions-rs/toolchain@v1, actions-rs/cargo@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
core-cargo-test / core-cargo-test (macos-latest, x86_64-apple-darwin)
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
core-cargo-test / core-cargo-test (macos-latest, x86_64-apple-darwin)
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
core-cargo-test / core-cargo-test (macos-latest, x86_64-apple-darwin)
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
core-cargo-test / core-cargo-test (macos-latest, x86_64-apple-darwin)
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
core-cargo-test / core-cargo-test (macos-latest, x86_64-apple-darwin)
failed to parse serde attribute
core-cargo-test / core-cargo-test (macos-latest, x86_64-apple-darwin)
failed to parse serde attribute
core-cargo-test / core-cargo-test (macos-latest, x86_64-apple-darwin)
failed to parse serde attribute
core-cargo-test / core-cargo-test (macos-latest, x86_64-apple-darwin)
failed to parse serde attribute
core-cargo-test / core-cargo-test (macos-latest, x86_64-apple-darwin)
failed to parse serde attribute
core-cargo-test / core-cargo-test (macos-latest, x86_64-apple-darwin)
failed to parse serde attribute
core-cargo-test / core-cargo-test (macos-latest, x86_64-apple-darwin)
failed to parse serde attribute
core-cargo-test / core-cargo-test (macos-latest, x86_64-apple-darwin)
failed to parse serde attribute
core-cargo-test / core-cargo-test (macos-latest, x86_64-apple-darwin)
failed to parse serde attribute
core-cargo-test / core-cargo-test (macos-latest, x86_64-apple-darwin)
failed to parse serde attribute