Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

console scroll change #254

Merged
merged 4 commits into from
May 27, 2023
Merged

console scroll change #254

merged 4 commits into from
May 27, 2023

Conversation

seliayeu
Copy link
Contributor

makes console no longer scroll to the bottom instantly when you go to the page and the autoScrollThreshold is down to 10 meaning that you have to be closer to the bottom for it to scroll!

@netlify
Copy link

netlify bot commented May 18, 2023

Deploy Preview for lodestone-dashboard ready!

Name Link
🔨 Latest commit cfa06b9
🔍 Latest deploy log https://app.netlify.com/sites/lodestone-dashboard/deploys/646d4479974cb60008aca318
😎 Deploy Preview https://deploy-preview-254--lodestone-dashboard.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@seliayeu seliayeu linked an issue May 18, 2023 that may be closed by this pull request
@netlify
Copy link

netlify bot commented May 18, 2023

Deploy Preview for lodestone-storybook ready!

Name Link
🔨 Latest commit cfa06b9
🔍 Latest deploy log https://app.netlify.com/sites/lodestone-storybook/deploys/646d4479b6055000087797fc
😎 Deploy Preview https://deploy-preview-254--lodestone-storybook.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

src/components/GameConsole.tsx Outdated Show resolved Hide resolved
Ynng
Ynng previously approved these changes May 23, 2023
Copy link
Member

@Ynng Ynng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@Ynng Ynng changed the base branch from main to dev May 23, 2023 22:56
@Ynng Ynng changed the base branch from dev to main May 23, 2023 22:56
@Ynng Ynng dismissed their stale review May 23, 2023 22:56

The base branch was changed.

@Ynng Ynng merged commit fb96ec5 into main May 27, 2023
4 checks passed
@Ynng Ynng deleted the console-scroll-change branch May 27, 2023 18:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Do not scroll bottom on new console output
2 participants