Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make notification icon brighter when there's a notification #258

Merged
merged 7 commits into from
Jun 8, 2023

Conversation

seliayeu
Copy link
Contributor

No description provided.

@seliayeu seliayeu requested a review from Ynng May 22, 2023 21:45
@netlify
Copy link

netlify bot commented May 22, 2023

Deploy Preview for lodestone-dashboard ready!

Name Link
🔨 Latest commit 0bbdd0a
🔍 Latest deploy log https://app.netlify.com/sites/lodestone-dashboard/deploys/6477f11672715000083adcfa
😎 Deploy Preview https://deploy-preview-258--lodestone-dashboard.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@netlify
Copy link

netlify bot commented May 22, 2023

Deploy Preview for lodestone-storybook ready!

Name Link
🔨 Latest commit 0bbdd0a
🔍 Latest deploy log https://app.netlify.com/sites/lodestone-storybook/deploys/6477f116257bb40008c1da7c
😎 Deploy Preview https://deploy-preview-258--lodestone-storybook.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@Ynng Ynng changed the base branch from main to dev June 1, 2023 00:56
@@ -287,6 +294,7 @@ export const useEventStream = () => {
title: `Macro ${macro_pid} errored on ${uuid}: ${error_msg}`,
event,
type: 'add',
fresh: fresh,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we can replace fresh: fresh with just fresh

@Ynng
Copy link
Member

Ynng commented Jun 1, 2023

image

The core name in the navbar is folding mistakenly

@Ynng
Copy link
Member

Ynng commented Jun 1, 2023

The red dot feels a little small
image

Copy link
Member

@Ynng Ynng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me!
sorry for the delay, next time if I forgot about a pr please re-request review or just merge it

@Ynng Ynng merged commit 5d3739b into dev Jun 8, 2023
4 checks passed
@Ynng Ynng deleted the notification-update branch June 8, 2023 00:34
@seliayeu
Copy link
Contributor Author

seliayeu commented Jun 8, 2023

if i don't forget too lmao

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants