macro config parsing in core #319
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for lodestone-dashboard canceled.
|
✅ Deploy Preview for lodestone-storybook canceled.
|
C0W0
force-pushed
the
core_macro_config_parsing
branch
from
6bc8037
to
f2ab57e
Compare
|
I think this PR is directed at the wrong branch, |
CheatCod
requested changes
Jul 27, 2023
CheatCod
requested changes
Jul 30, 2023
|
@CheatCod added comments and fixed those irrelevant files. Just needed to do a merge with dev to get up to date. Also added unit test |
CheatCod
approved these changes
Aug 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently, there is no easy way for macro developers to render custom configs to the front end. This PR contains Typescript parsing logic, which runs independently of the Deno runtime to extract custom config templates defined by the macro developer into SettingManifests. We might need some corresponding frontend logic to test it out.
Type of change
Note: make sure your files are formatted with rust-analyzer